Add TryClone trait #56994
Closed
Add TryClone trait #56994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
clarfonthey
force-pushed
the
try_clone
branch
from
e7d5d53 to
01252c1
Compare
This comment has been minimized.
This comment has been minimized.
clarfonthey
force-pushed
the
try_clone
branch
from
01252c1 to
0f9dedd
Compare
Collaborator
|
☔ The latest upstream changes (presumably #57108) made this pull request unmergeable. Please resolve the merge conflicts. |
clarfonthey
force-pushed
the
try_clone
branch
from
0f9dedd to
641c9cd
Compare
clarfonthey
force-pushed
the
try_clone
branch
from
641c9cd to
6ae87e0
Compare
Contributor
|
Triage... reassigning randomly to someone else on libs... r? @SimonSapin |
Contributor
|
I don’t really see the point of this trait. Would any code ever use it as a bound on a generic type parameter? I think this needs more motivation than analogy and “seems reasonable”. |
|
ping from triage @clarcharr closing this based on the last comment. Thanks for contributing. If you have a better reason and motivation behind this you can ask it to be reopened or create a new pull request. |
Dylan-DPC-zz
added
S-inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presumably, this will require an RFC to properly stabilise, but this seems simple enough to warrant opening a PR. I doubt the API would be substantially different from the one I've provided, as it's very simple.
Basically, there are a few things in the standard library that have a
try_clonemethod, and it seems very reasonable to add aTryClonetrait as an analogue toTryFromandTryInto. I've personally run into a few cases where it'd be useful to have a trait like this, although again, it's up to others on whether this is useful.A few unanswered questions:
#[derive(TryClone)]even make sense? What would the error type be?try_clone_from? What would the behaviour be if the clone fails?